-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: run tests on linux and windows #233
chore: run tests on linux and windows #233
Conversation
✔️ Deploy Preview for arcus-scripting canceled. 🔨 Explore the source changes: 6969553 🔍 Inspect the deploy log: https://app.netlify.com/sites/arcus-scripting/deploys/619622c63462fd000773baa7 |
…nmoreels/arcus.scripting into chore/run-linux-and-windows
src/Arcus.Scripting.Tests.Integration/Arcus.Scripting.Sql.tests.ps1
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is OK for me, although I don't see what has been changed on that sql statement :?
There was a missing column selection in the statement. I added |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great idea to make sure that tests run both on linux and windows!
Woops, was merged without @pim-simons 's consent. Sorry! Let me know if there is anything you would want to change! |
😱 Honestly no problem, I see @fgheysels reviewed and approved it and I don't see any issues 👍🏻 |
Change build/release pipeline to run (by default) the unit/integration tests on both Linux and Windows build machines.
Closes #227