Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: run tests on linux and windows #233

Merged

Conversation

stijnmoreels
Copy link
Member

Change build/release pipeline to run (by default) the unit/integration tests on both Linux and Windows build machines.

Closes #227

@netlify
Copy link

netlify bot commented Nov 12, 2021

✔️ Deploy Preview for arcus-scripting canceled.

🔨 Explore the source changes: 6969553

🔍 Inspect the deploy log: https://app.netlify.com/sites/arcus-scripting/deploys/619622c63462fd000773baa7

@stijnmoreels stijnmoreels marked this pull request as draft November 12, 2021 12:29
@stijnmoreels stijnmoreels changed the title chore: run tests on linux and windows chore: run tests on linux and windows (🚧) Nov 12, 2021
build/ci-build.yml Outdated Show resolved Hide resolved
@stijnmoreels stijnmoreels changed the title chore: run tests on linux and windows (🚧) chore: run tests on linux and windows Nov 12, 2021
@stijnmoreels stijnmoreels marked this pull request as ready for review November 12, 2021 13:50
Copy link
Member

@fgheysels fgheysels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is OK for me, although I don't see what has been changed on that sql statement :?

@stijnmoreels
Copy link
Member Author

I think this is OK for me, although I don't see what has been changed on that sql statement :?

There was a missing column selection in the statement. I added TABLE_NAME to have something.

Copy link
Member

@fgheysels fgheysels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great idea to make sure that tests run both on linux and windows!

@fgheysels fgheysels enabled auto-merge (squash) November 30, 2021 13:10
@stijnmoreels stijnmoreels merged commit 2b7e716 into arcus-azure:master Nov 30, 2021
@stijnmoreels stijnmoreels deleted the chore/run-linux-and-windows branch November 30, 2021 13:31
@stijnmoreels
Copy link
Member Author

stijnmoreels commented Nov 30, 2021

Woops, was merged without @pim-simons 's consent. Sorry! Let me know if there is anything you would want to change!

@pim-simons
Copy link
Contributor

Woops, was merged without @pim-simons 's consent. Sorry! Let me know if there is anything you would want to change!

😱

Honestly no problem, I see @fgheysels reviewed and approved it and I don't see any issues 👍🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Automatically run integration tests on Windows & Linux
3 participants